Upgrade stripe Python package to the latest version #4904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humitos
commented
Nov 15, 2018
| @@ -222,7 +222,7 @@ def test_update_subscription_plan(self): | |||
| mock.ANY, | |||
| mock.ANY), | |||
| mock.call('post', | |||
| '/v1/customers/cus_12345/subscriptions/sub_12345', | |||
| '/v1/subscriptions/sub_12345', | |||
There was a problem hiding this comment.
| @@ -69,7 +69,7 @@ def get_subscription(self): | |||
| customer = self.get_customer() | |||
|
|
|||
| # TODO get the first subscription more intelligently | |||
| subscriptions = customer.subscriptions.all(limit=5) | |||
| subscriptions = customer.subscriptions.list(limit=5) | |||
There was a problem hiding this comment.
Codecov Report
@@ Coverage Diff @@
## master #4904 +/- ##
=======================================
Coverage 76.65% 76.65%
=======================================
Files 158 158
Lines 10057 10057
Branches 1269 1269
=======================================
Hits 7709 7709
Misses 2007 2007
Partials 341 341
|
agjohnson
approved these changes
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration guide: https://github.com/stripe/stripe-python/wiki/Migration-guide-for-v2
https://github.com/stripe/stripe-python/blob/master/CHANGELOG.md
Related https://github.com/rtfd/readthedocs-corporate/pull/422